Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show subinterfaces status #642

Merged
merged 20 commits into from
Nov 5, 2019
Merged

show subinterfaces status #642

merged 20 commits into from
Nov 5, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Sep 12, 2019 •
edited
Loading

- What I did
Implement HLD sonic-net/SONiC#420

- How I did it

- How to verify it
On mlnx dut

$ intfutil status subport
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

$ intfutil status Ethernet64.10
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

$ show subinterfaces --help
Usage: show subinterfaces [OPTIONS] COMMAND [ARGS]...

  Show details of the sub port interfaces

Options:
  -?, -h, --help  Show this message and exit.

Commands:
  status  Show sub port interface status information

$ show subinterfaces status
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

$ show subinterfaces status Ethernet64.10
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

$ show subinterfaces status etp17.10
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

Unit test cases:

'show interfaces status' / 'intfutil status'
'show interfaces status --verbose'
'show subinterfaces status' / 'intfutil status subport'
'show subinterfaces status --verbose'
show status of single sub port interface
show '--verbose' status of single sub port interface
show status of single sub port interface in alias naming mode
show '--verbose' status of single sub port interface in alias naming mode

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

$ show interfaces status etp17.10     
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

$ show interfaces status Ethernet64.10
  Sub port interface    Speed    MTU    Vlan    Admin                 Type
--------------------  -------  -----  ------  -------  -------------------
       Ethernet64.10     100G   9100      10       up  dot1q-encapsulation

-->

@wendani
Copy link
Contributor Author

wendani commented Sep 18, 2019

retest this please

qiluo-msft
qiluo-msft reviewed Sep 25, 2019
View reviewed changes
scripts/intfutil Outdated Show resolved Hide resolved
qiluo-msft
qiluo-msft reviewed Sep 25, 2019
View reviewed changes
show/main.py Outdated Show resolved Hide resolved
qiluo-msft
qiluo-msft requested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

@wendani
Copy link
Contributor Author

wendani commented Sep 27, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Oct 16, 2019

keep show interface status the same, only show sub interface in show subinterface status.

@wendani
Copy link
Contributor Author

wendani commented Oct 16, 2019

Done #642 (comment)

@wendani
Copy link
Contributor Author

wendani commented Oct 17, 2019

retest this please

2 similar comments
@wendani
Copy link
Contributor Author

wendani commented Oct 17, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Oct 17, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Oct 18, 2019

would like you add unit test for your newly added commands, example below.

https://github.com/Azure/sonic-utilities/tree/master/sonic-utilities-tests

@wendani wendani force-pushed the sub_intf_show_master branch 3 times, most recently from 215e5ec to 45f41d1 Compare November 4, 2019 00:36
@wendani wendani force-pushed the sub_intf_show_master branch 4 times, most recently from 205446f to 8480ae3 Compare November 4, 2019 01:25
@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019 •
edited
Loading

Done adding unit test #642 (comment)

🚢

@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019

retest this please

5 similar comments
@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 4, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Nov 5, 2019

test_fdb.TestFdb.test_FdbAddedAfterMemberCreated failure is new failure which is unrelated to this change.

@lguohan lguohan merged commit 1b0d542 into sonic-net:master Nov 5, 2019
@wendani
Copy link
Contributor Author

wendani commented Nov 6, 2019

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque Awaiting requested review from jleveque

@prsunny prsunny Awaiting requested review from prsunny

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wendani @lguohan @qiluo-msft